Script for docker deploy commands #904
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 1ae69ef and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
@aryanpingle Thanks for the PR. Please make the following changes.
- Move the
Makefiletoscript/ - Please check best practices for loading environment variables into make files. If there is no specific recommendation, let the Makefile load environment variables from a separate file:
script/.env. If the file does not exist, make can create them from relative paths like you did here. - Update
env.shandenv.ps1to install make toolchain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Makefile with recipes like
start-http,stop-httpsto simplify the process of running docker compose commands on a DTaaS server.This is just a convenience file for running commonly used commands, and only works on Linux/MacOS. Needs to be a cross-platform solution like a Python script inside venv.